Revert "Use clang-tidy to use nullptr instead of 0 or NULL in e direc… #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @mahrud for creating this branch and reverting the 2886 commit. |
|
@antonleykin, @mahrud, @DanGrayson OK if I merge this pull request which rolls back one commit (which we can easily do later)? If so, I'll merge it. |
|
Go ahead. |
|
I’m okay with that.
…On Fri, Sep 8, 2023 at 7:22 AM Daniel R. Grayson ***@***.***> wrote:
Go ahead.
—
Reply to this email directly, view it on GitHub
<#2925 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANPI3HU6EHPFHK6VKO35RDXZL5W7ANCNFSM6AAAAAA4N2SKAA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I don't recall creating this branch! I'm fine with either merging this or Anton's suggestion, which is to only revert the files that are changed by this branch: M2/Macaulay2/d/CMakeLists.txt | 2 +
M2/Macaulay2/d/Makefile.files.in | 4 +-
M2/Macaulay2/d/actors4.d | 4 +-
M2/Macaulay2/d/interface.dd | 227 +--------
M2/Macaulay2/d/monoid.dd | 51 +++
M2/Macaulay2/d/monomial_ordering.dd | 190 ++++++++
M2/Macaulay2/e/CMakeLists.txt | 5 +-
M2/Macaulay2/e/M2FreeAlgebra.cpp | 13 +-
M2/Macaulay2/e/M2FreeAlgebra.hpp | 1 -
M2/Macaulay2/e/M2FreeAlgebraQuotient.cpp | 7 +-
M2/Macaulay2/e/M2FreeAlgebraQuotient.hpp | 1 -
M2/Macaulay2/e/Makefile.files | 3 +-
M2/Macaulay2/e/MonomialOrder.cpp | 606 ++++++++++++++++++++++++
M2/Macaulay2/e/MonomialOrder.hpp | 250 ++++++++++
M2/Macaulay2/e/MonomialOrderOld.cpp | 1680 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
M2/Macaulay2/e/MonomialOrderOld.hpp | 113 +++++
M2/Macaulay2/e/NAG.cpp | 9 +-
M2/Macaulay2/e/NCAlgebras/FreeAlgebra.cpp | 5 -
M2/Macaulay2/e/NCAlgebras/FreeAlgebra.hpp | 8 +-
M2/Macaulay2/e/NCAlgebras/FreeAlgebraQuotient.cpp | 8 +-
M2/Macaulay2/e/NCAlgebras/FreeAlgebraQuotient.hpp | 8 +-
M2/Macaulay2/e/engine-includes.hpp | 2 +
M2/Macaulay2/e/frac.cpp | 18 +-
M2/Macaulay2/e/frac.hpp | 9 +-
M2/Macaulay2/e/freemod.cpp | 1 +
M2/Macaulay2/e/imonorder.cpp | 656 --------------------------
M2/Macaulay2/e/imonorder.hpp | 67 ---
M2/Macaulay2/e/interface/freemodule.cpp | 17 +-
M2/Macaulay2/e/interface/matrix.cpp | 7 +-
M2/Macaulay2/e/interface/monoid.cpp | 224 +--------
M2/Macaulay2/e/interface/monoid.h | 37 +-
M2/Macaulay2/e/interface/monomial-ordering.cpp | 834 +--------------------------------
M2/Macaulay2/e/interface/monomial-ordering.h | 31 +-
M2/Macaulay2/e/interface/ringelement.cpp | 29 +-
M2/Macaulay2/e/interface/ringelement.h | 1 +
M2/Macaulay2/e/localring.cpp | 20 +-
M2/Macaulay2/e/localring.hpp | 9 +-
M2/Macaulay2/e/matrix.cpp | 4 +-
M2/Macaulay2/e/matrix.hpp | 2 +-
M2/Macaulay2/e/monideal.cpp | 3 +-
M2/Macaulay2/e/monideal.hpp | 6 +-
M2/Macaulay2/e/monoid.cpp | 334 ++++++--------
M2/Macaulay2/e/monoid.hpp | 153 ++++---
M2/Macaulay2/e/monordering.hpp | 40 --
M2/Macaulay2/e/poly.cpp | 27 +-
M2/Macaulay2/e/poly.hpp | 13 +-
M2/Macaulay2/e/polyquotient.cpp | 2 +-
M2/Macaulay2/e/polyquotient.hpp | 17 +-
M2/Macaulay2/e/polyring.hpp | 11 +-
M2/Macaulay2/e/reducedgb.cpp | 3 +-
M2/Macaulay2/e/relem.cpp | 57 +--
M2/Macaulay2/e/relem.hpp | 10 +-
M2/Macaulay2/e/ring-vecs.cpp | 12 +-
M2/Macaulay2/e/ring.cpp | 22 +-
M2/Macaulay2/e/ring.hpp | 32 +-
M2/Macaulay2/e/unit-tests/MonomialOrderTest.cpp | 172 +++++++
M2/Macaulay2/e/unit-tests/NCGroebnerTest.cpp | 4 +- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tory."
This commit caused problems with another branch (feature/monoids) where it proved difficult to clean up and remove conflicts with these changes. Instead, we will rerun the clang-tidy code that created 2886 later, after that code is merged in.