Improvements in local cohomology computations #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point M2 no longer allowed for mutable matrices to be used in `sub()`. Instances of this was fixed by converting the mutable matrices to a matrix.
Converted mutable matrices to matrices in instances of `sub()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes made to the BernsteinSato package by the Local Cohomology group during the M2 workshop at AIM.
We made improvements to the Walther strategy of localCohom. Previously, it computed the entire Cech complex; now it only computes the parts that are really needed. Also, it previously duplicated the computations of annihilators of f^s---the most expensive part of the algorithm.
In addition, we made improvements in the documentation, and changed the name of one of the implementations of AnnFs, which was not computing annihilators, but actually Malgrange ideals.