Varieties: reorganizing varieties.m2 #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahrud
force-pushed
the
feature/varieties
branch
from
7a40247
to
09f1d37
Compare
|
@ggsmith @mikestillman could you review this PR? There are a lot more changes to come. |
|
@mahrud Will do! |
|
@DanGrayson I'm confused, did you accept this pull request? It is still open? |
Yes, I merged it, and it's closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a sequence of PR's towards a Varieties package.
The changes to varieties.m2 look like a lot, but are purely reorganization/non-mathematical and will make reviewing future changes easier.