Update Python package to support Python 3.12 #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting this to a draft until I figure out the segfault issue. |
|
I think what was happening is that with Python 3.12, some various thread-related things that Macaulay2 was doing was monkeying around with Python's thread-related things that were set up with |
d-torrance
changed the title
From gmpy2 2.2.0a1
Two reasons:
* Why initialize Python if we're not going to use it? This is
probably true over 99% of the time.
* With Python 3.12, something in the M2 startup was messing with
Python's threads ("failed to read thread state" errors when running
the "pythonMain" function and segfaults doing pretty much anything
else). Waiting until all that is finished fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From gmpy2 2.2.0a1
This should fix the compilation errors we're getting with Python 3.12 (like this one). I've been getting strange segfaults with Python 3.12 in Debian unstable, but I'm curious what happens with the GitHub builds...