Add augmented assignment operators to Macaulay2 language #3079
Commits on Jan 24, 2024
-
Add augmented assignment operator symbols
One for most flexible binary operators (omitting ones that would introduce ambiguity or give syntax errors) with the same precedence as = (to match C).
-
-
-
-
-
Identify augmented assignment methods as assignment methods
This way it won't complain when we try to install a function with two arguments.
-
Add augmented assignment operators to operatorAttributes hash table
They're binary and they're flexible, but they're a little different than the members of flexibleBinaryOperators. In particular, we don't want to run installAssignmentMethod on them, which is why we keep them separate from flexibleBinaryOperators.
-
Provide fallback for user-defined augmented assignment methods
If the method returns the "Default" symbol, then fall back to the usual behavior. This is useful for example for the Python package, where we'd like += to call the __iadd__ method, but only if it exists.
-
-
-
-
-
-
-
Add new evaluatedCode member of Code union
This will be used by augmented assignment. The problem was that we first want to check if a user-defined method for augmented assignment is installed, which requires evaluating the code on the left-hand side of the operator. But if we *don't* use a user-defined method (which will be the case most of the time), then we want the original code, since that's what the binary operators expect. The solution is to create a member of the Code union that saves the evaluated code. Then we can evaluate early on but still call the binary operators later if need.
-
Refactor augmented assignment so we don't evaluate things twice
Evaluate everything immediately but store it as evaluatedCode for later.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.