Deprecate support for MPIR #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mahrud
commented
May 15, 2024
•
mahrud
commented
- deprecated support for MPIR
|
Why FLINT 2.8.5? Ubuntu 22.04 still has FLINT 2.8.4, and Macaulay2 still builds fine using FLINT 2.6.3 (which I backported for the Ubuntu 18.04 and 20.04 PPA's). |
|
3 test builds are failing |
|
Could you fix the failing test builds? |
mahrud
force-pushed
the
quickfix/remove-mpir
branch
from
94d9a6e
to
8380178
Compare
|
Looks good to me, but I suppose we should probably do the same thing for the autotools build. There's still a bunch of mpir cruft in configure.ac, for example. I can work on it and push to your branch, if you'd like. |
|
Sounds good! |
d-torrance
approved these changes
Jun 20, 2024
d-torrance
force-pushed
the
quickfix/remove-mpir
branch
2 times, most recently
from
ee95daa
to
172fd15
Compare
mahrud
commented
Jun 20, 2024
d-torrance
force-pushed
the
quickfix/remove-mpir
branch
from
172fd15
to
a5913b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.