Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local variable for Galois field instead of getSymbol #3255

Closed

Conversation

d-torrance
Copy link
Member

Otherwise, we run into issues when "a" is used elsewhere. After the fix:

i2 : depth(GF(2)[a]/ideal(a^2))

o2 = 0

i3 : depth(GF(5)[a,b,c]/ideal(a^3+b^3+c^3))

o3 = 2

Closes: #3254

@d-torrance
Copy link
Member Author

It turns out that this is kind of a breaking change because a couple packages assumed that a is always available as a generator of the field after calling GF. But this was undocumented and led to bugs.

@d-torrance
Copy link
Member Author

I'm closing this -- this is too much of a breaking change. I think maybe GF just needs better documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant