Delete check for program licenses directory #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was left over from when "copyright" was a string, which is no longer the case. Also, the next thing after the "then" at the end of the line was the definition of the "path" variable. So if the "program licenses" directory doesn't exist (e.g., in the Debian/Ubuntu package where we don't vendor any 3rd party programs or libraries), then we immediately got the following error: /usr/share/Macaulay2/Core/startup.m2:583:16:(0): error: expected argument 1 to be a list or sequence This was from a call to "join", which expects lists and sequences, but argument 1 was "path", which was still just a symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another short followup to #3240. I forgot to delete a line that was left over from when
copyrightwas a string, which is no longer the case.Also, the next thing after the
thenat the end of the line was the definition of thepathvariable. So if the"program licenses"directory doesn't exist (e.g., in the Debian/Ubuntu package where we don't vendor any 3rd party programs or libraries), then we immediately got the following error:This was from a call to
join, which expects lists and sequences, but argument 1 waspath, which was still just a symbol.