Export changeDirectory #3269
Merged
Export changeDirectory #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahrud
reviewed
May 30, 2024
M2/Macaulay2/d/actors5.d
Outdated
| changeDirectory(dir:string):Expr := ( | ||
| if chdir(expandFileName(dir)) == -1 | ||
| then buildErrorPacket(syscallErrorMessage("changing directory")) | ||
| else nullE); |
There was a problem hiding this comment.
You might want to have it return whatever currentDirectory() returns. This is useful to know the exact new address (e.g. if symlink resolutions happened) without running another command.
On that note, it would be good if makeDirectory() also returned the address so you could do changeDirectory makeDirectory "~/foo".
* Expand "~" to user's home directory * If no input, go to user's home directory * Return the new working directory as a string
d-torrance
force-pushed
the
change-directory
branch
from
f73b8e0
to
bbbd5e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've often wanted the option to change the current working directory inside M2 (e.g, if without realizing I run
M-x M2inside Emacs when the active buffer is visiting some file in some strange directory).It turns out that a
changeDirectoryfunction already exists, but it just wasn't exported!We update it slightly (allowing the expansion of
~to the user's home directory and changing to the home directory when there's no input), document it, and add unit tests.