Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added try .. then .. clause #3375

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Added try .. then .. clause #3375

merged 2 commits into from
Aug 7, 2024

Conversation

mahrud
Copy link
Member

@mahrud mahrud commented Jul 22, 2024

Closes #2572.

@mahrud mahrud requested a review from d-torrance July 22, 2024 02:11
@pzinn
Copy link
Contributor

pzinn commented Jul 22, 2024

note that there will probably be a merge conflict with #3363 due to changes to convertr.d. though it should be easy to fix.

@mahrud mahrud marked this pull request as draft July 22, 2024 07:55
@mahrud
Copy link
Member Author

mahrud commented Jul 22, 2024

Good point, I'll draft it until yours is merged.

@mahrud
Copy link
Member Author

mahrud commented Aug 7, 2024

I think the other PR might take some time, so undrafting this. Resolving the conflicts this way shouldn't be too hard either.

@mahrud mahrud marked this pull request as ready for review August 7, 2024 05:56
@d-torrance d-torrance merged commit 155ba1d into Macaulay2:development Aug 7, 2024
6 checks passed
@mahrud mahrud deleted the quickfix/try-then branch August 11, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-torrance d-torrance d-torrance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahrud @pzinn @d-torrance