-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various updates to methods / installPackage / package / etc. #3382
Conversation
mahrud
commented
Jul 27, 2024
- set warnings to be always printed
- added mutable symbols to items in package docs
- added briefDocumentation for method keys
- added routine that checks everything is documented
- overhauled warning and errors in installPackage
- fixed an issue in (package, Symbol), (package, Sequence)
- changed default errorDepth in CMake targets
- fixed methods to not show unexported methods
- simplified importFrom and added warning
- deleted unused key in Package
- added missing documentation for MonomialIdeal:RingElement
- moved and fixed (sort, List, Function)
- moved (jacobian, RingElement) to Core
- added helpers subclasses, descendants, allobjects
- downgraded a fatal error to an error signal
- undocumented all methods of Expressions
- added error when an unexported type is documented
- exported missing Bertini symbol
- exported missing VectorGraphics symbol
@pzinn are the changes related to documentation of expressions here acceptable to you? |
As far as I understand you've only "undocumented" things that were not documented anyway. so I can't imagine why anyone would object to that. |
Not quite, there are two differences:
|
I see. That's a bit radical. Maybe we do want to keep some of these methods listed? is there any way to do that w/o actually documenting them? |
Exactly, this is why I've been trying to ask you which things are important and should appear in the documentation! Adding them as secondary keys is the only other way I can think of (e.g. with this pr, M2/M2/Macaulay2/packages/Macaulay2Doc/debugging.m2 Lines 315 to 318 in 18a83cd
I think this way undocumenting by default, except for nodes intentionally added as secondaries is probably easier to maintain. ps: note that all the other methods still appear under |
e.g. ? (map, Ring, Ring)
Before this, after debug Core, documentableMethods would fail, and package would show Macaulay2Doc instead of Core for methods. Still, package is not perfect for sequences.
Can this be merged? #3388 is on top of this. |
|
||
-- this should list (net/info, HypertextContainer), | ||
-- even though HypertextContainer is not exported. | ||
assert(2 == length methods parent class help()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason to call help()
here and not just use parent DIV
? Or if we're trying to avoid importing DIV
, code
would work since it also returns a DIV
object.
Calling help()
can take a fair amount of memory (I seem to remember an issue about this but I can't find it...) and one of the PPA builds just crashed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure, we can replace this with code
of something. The important point is that we want to make sure methods
still finds things for DIV
even though it is not exported, because users can still access these methods, so they should be listed.