New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated release checklist #3385

Merged

mahrud merged 11 commits into Macaulay2:development from mahrud:quickfix/release-checklist

Aug 27, 2024

Member

mahrud commented Jul 31, 2024

limited package headlines to 100 characters
- also fixes the top node check, which wasn't working.
removed Reload => true from packages
implemented uniformity in headlines (cf. 7a7e6f9)
removed line breaks from package headlines

I'll seek approval from authors of affected packages in the comments.

mahrud commented

View reviewed changes

M2/Macaulay2/packages/A1BrouwerDegrees.m2 Outdated Show resolved Hide resolved

mahrud commented

View reviewed changes

M2/Macaulay2/packages/CellularResolutions.m2 Show resolved Hide resolved

mahrud commented

View reviewed changes

M2/Macaulay2/packages/CharacteristicClasses.m2 Show resolved Hide resolved

mahrud commented

View reviewed changes

M2/Macaulay2/packages/GeometricDecomposability.m2 Show resolved Hide resolved

mahrud commented

View reviewed changes

M2/Macaulay2/packages/MultigradedImplicitization.m2 Show resolved Hide resolved

mahrud commented

View reviewed changes

M2/Macaulay2/packages/SagbiGbDetection.m2 Show resolved Hide resolved

mahrud commented

View reviewed changes

M2/Macaulay2/packages/VectorGraphics.m2 Show resolved Hide resolved

mahrud added 8 commits

August 23, 2024 22:02


          limited package headlines to 100 characters

97dc244


          removed Reload => true from packages

7f8afef


          implemented uniformity in headlines (cf. 7a7e6f9)


          removed line breaks from package headlines

6c7ba9f


          fixed input checking in newPackage

cf654fb


          removed extra spaces from author name in GroebnerStrata

3209e5b


          added Node to the documentation template

28c10f8


          removed 'newPackage select' hacks

b84ba07

mahrud force-pushed the quickfix/release-checklist branch from d2a41ec to b84ba07 Compare

August 23, 2024 20:02

mahrud marked this pull request as ready for review

August 23, 2024 20:03

mahrud requested a review from d-torrance

August 23, 2024 20:03


          fixed newPackage to permit terminal null entries

b0cef92

mahrud force-pushed the quickfix/release-checklist branch from 12cd437 to b0cef92 Compare

August 25, 2024 14:22

mahrud and others added 2 commits

August 25, 2024 21:30


          limited headline of Msolve to 100 chars

816f156


          Add stub documentation page for RInterface when R or libffi missing

6380edc

Member

d-torrance commented Aug 27, 2024

I just pushed a commit that should fix the RInterface error (we were missing the top level node when R is missing during the build).

d-torrance approved these changes

View reviewed changes

Member

d-torrance commented Aug 27, 2024

Is this ready to merge?

Member Author

mahrud commented Aug 27, 2024

I think everyone I tagged responded.

mahrud merged commit 5db7db6 into Macaulay2:development

5 checks passed

mahrud deleted the quickfix/release-checklist branch

August 27, 2024 15:55

d-torrance mentioned this pull request

Update RealRoots package to version 1.0 to match JSAG #3539

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet