Update PositivityToricBundles to v1.9 #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the method wellformedBundleFiltrations, updated documentation accordingly and added a corresponding test. Several methods make the implicity assumption that the filtration steps are stored in an ascending manner. This is not true for bundles which are created by the methods dual or tensor (maybe others) from the package ToricVectorBundles. The method wellformedBundleFiltrations ensures that the filtration steps are stored in a well-formed manner, suitable for the methods of this package.
d-torrance
reviewed
Aug 11, 2024
d-torrance
reviewed
Aug 11, 2024
mahrud
reviewed
Aug 11, 2024
Co-authored-by: Mahrud Sayrafi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the method
wellformedBundleFiltrations, updated documentation accordingly and added a corresponding test.Several methods make the implicit assumption that the filtration steps are stored in an ascending manner. This is not true for bundles which are created by the methods
dualortensor(maybe others) from the packageToricVectorBundles. The methodwellformedBundleFiltrationsensures that the filtration steps are stored in a well-formed manner, suitable for the methods of this package.