Fix code location when reading history from a file #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns value of history_length variable from readline history.
When reading the history from a file, we need to add the number of lines loaded from previous sessions when calling getHistory to get the correct lines of code. Closes: Macaulay2#3415
mahrud
reviewed
Aug 20, 2024
| @@ -143,6 +143,8 @@ char *system_getHistory(const int n) | |||
| return NULL; | |||
| } | |||
|
|
|||
| int system_historyLength() { return history_length; } | |||
There was a problem hiding this comment.
Is it possible to directly export this variable to the top-level?
There was a problem hiding this comment.
That was my first thought, too. But I couldn't figure it out -- if we do something like setupvar("historyLength", toExpr(Ccode(int, "history_length"))), then it will just be 0 since it gets assigned at startup and never updates.
There was a problem hiding this comment.
But we'd still need to dereference it when we need its value, so we'd have to call some kind of function. I suppose we could add some variation of setupvar that does this, but I'm not sure if it's worth it.
|
Do we have a mechanism to test this? Not sure how exactly to test readline ... |
mahrud
approved these changes
Aug 20, 2024
mahrud
reviewed
Aug 20, 2024
mahrud
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At startup, we use a new compiled function (
historyLength(), which returns the value of readline'shistory_lengthvariable) to determine how many lines of history we've saved from previous sessions. We add this value to the line numbers of any code fromstdiowhen callingcodeso we get the correct lines back when callinggetHistory.Before
After
Closes: #3415