Fixed order of FilePosition components #3435
Conversation
|
To be clear, this PR doesn't change any top-level behavior whatsoever. You can verify with the tests I added, and if you find anything that is changed we should add them as tests to make sure nothing changes by accident. |
|
yes I will provide more tests, I have a list of them, I just forgot to include them in my PR |
M2/Macaulay2/tests/normal/locate.m2
Outdated
There was a problem hiding this comment.
thinking about tests -- by defining both f and F, are you suggesting they should have different locations? I think I vaguely considered that at some point (maybe F should only have the right of ->?) but rejected it, don't remember why though.
There was a problem hiding this comment.
the simplest one that has all locations distinct is probably
f = () -> 1 + 2
toSequence locate((pseudocode f)_4)
There was a problem hiding this comment.
most of my "tests" actually involve errors -- not sure how to turn them into assert type tests.
There was a problem hiding this comment.
are you suggesting they should have different locations
I can see it both ways, but I'm just adding the test lines so if they change unintentionally we find out.
There was a problem hiding this comment.
most of my "tests" actually involve errors -- not sure how to turn them into
asserttype tests.
You can use capture. There are several examples of this already.
There was a problem hiding this comment.
OK. I think this can wait till my next PR on this kind of stuff.
There was a problem hiding this comment.
If you already have tests that you know what to expect and are correct now, just paste them here or send them to me and I can put them in.
mahrud
force-pushed
the
quickfix/locate
branch
from
e764aa4
to
ec05d21
Compare
mahrud
force-pushed
the
quickfix/locate
branch
from
ec05d21
to
85fc7fa
Compare
c.f. #3431 (comment)