Use unlimited virtual memory when running msolve tests (autotools) #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the tests fail using the default 400000 kB. Closes: Macaulay2#3428 [ci skip]
|
Perhaps you could request one of the authors to review? (In particular, I don't use the autotools build, and I'd rather not have to deal with it just to review this PR. If you're sure that it's correct then feel free to merge.) |
|
We have the limit in for a reason, so that tests (mostly) don't need to be run on large memory machines. How much memory is the msolve executable taking? |
|
Ok, that makes sense. I'll do some experiments and find a finite upper bound. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests fail using the default 400000 kB.
Closes: #3428
Here's a successful run of the tests after this change: https://github.com/d-torrance/M2/actions/runs/10552691192/job/29231880174