Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finite limit to virtual memory used when checking msolve #3438

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

d-torrance
Copy link
Member

Rather than allowing unlimited virtual memory, we increase the upper bound to 1.5 GB, which should still allow all the tests to pass.

Here's an example of the tests passing after this commit: https://github.com/d-torrance/M2/actions/runs/10561928026/job/29258736811

I ran the tests a bunch of times locally, incrementing the upper bound by 100,000 until they all passed. By 1.3 GB, they all passed but one (test/diff/diff_nonradical_shape-qq.sh), and then they all passed at 1.4 GB. I figured I'd round up a bit more to 1.5 GB just in case.

Rather than allowing unlimited virtual memory, we increase the upper
bound to 1.5 GB, which should still allow all the tests to pass.
@mahrud
Copy link
Member

mahrud commented Aug 28, 2024

(I just cancelled the builds because they weren't going to test this change anyway.)

@d-torrance
Copy link
Member Author

I'm going to go ahead and merge this and a couple other small autotools build-related PR's that have been open for a while (#3464 and and #3466) since there have been no objections. Feel free to revert!

@d-torrance d-torrance merged commit 54ed171 into Macaulay2:development Oct 8, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants