Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix with dual method in ToricVectorBundles #3445

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

sashahbc
Copy link
Contributor

@sashahbc sashahbc commented Aug 30, 2024

Fixing a bug in ToricVectorBundles with the dual method, as well as a change to the corresponding test which was incorrect mathematically. For example, the dual of O(1) ++ O(-3) on the projective line should be O(-1) ++ O(3).
Before:

i2 : F = projectiveSpaceFan 1;

i3 : T = weilToCartier({1,0},F) ++ weilToCartier({0,-3},F);

i4 : T#"filtrationMatricesTable" -- here is the table for O(1) ++ O(-3)

o4 = HashTable{| -1 | => | -1 0 |}
               | 1 | => | 0 3 |

o4 : HashTable

i5 : Tv = dual T;

i6 : Tv#"filtrationMatricesTable" -- this is the table for O(-1) ++ O(1), not the correct dual

o6 = HashTable{| -1 | => | 1 0 |}
               | 1 | => | 0 -1 |

o6 : HashTable

After:

i2 : F = projectiveSpaceFan 1;

i3 : T = weilToCartier({1,0},F) ++ weilToCartier({0,-3},F);

i4 : Tv = dual T;

i5 : Tv#"filtrationMatricesTable" -- this is the correct table

o5 = HashTable{| -1 | => | 1 0 |}
               | 1 | => | 0 -3 |

o5 : HashTable

@nilten
Copy link
Contributor

nilten commented Aug 30, 2024

Sasha discussed this change with me and I approve it.

@mahrud
Copy link
Member

mahrud commented Aug 31, 2024

Thanks!

@mahrud mahrud merged commit 48aefe9 into Macaulay2:development Aug 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants