Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "setup" functions in interpreter #3462

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

d-torrance
Copy link
Member

This is based on a few commits that I'd originally proposed in #3419.

We remove some of the setup family of functions in common.d (which are used for associating a symbol with its function) that weren't being used anywhere:

  • All of them that accept a Word argument.
  • setup(SymbolClosure, unop, unop) (for unary operators that are both prefix and postfix, of which we have none)
  • setupfun(string, unop)

We also remove setup(SymbolClosure, unop) since it was identical to setupop.

@mahrud
Copy link
Member

mahrud commented Sep 7, 2024

I probably won't have enough time to do this review for a few weeks, but then I'd like to take a better look at how and where setup-like functions are used, mainly because before removing them I want to make sure we can't make better simplifications elsewhere using them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants