Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VNumber.m2 #3473

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Update VNumber.m2 #3473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions M2/Macaulay2/packages/VNumber.m2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
newPackage(
"VNumber",
Version => "1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to increase the version number as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is not a problem, we can leave the current version. It was just a formal fix.

Date => "October 24, 2023",
Date => "September 12, 2024",
Authors => {{Name => "Antonino Ficarra", Email => "[email protected]", HomePage => "https://www.researchgate.net/profile/Antonino-Ficarra"},
{Name => "Emanuele Sgroi", Email => "[email protected]", HomePage => "https://www.researchgate.net/profile/Emanuele-Sgroi"}},
Headline => "compute v-number of homogeneous ideals and v-function of monomial ideals",
Expand Down Expand Up @@ -375,12 +375,12 @@ soc (Ideal, Ideal) := (I, P) -> (
XP := ring I;
if not(isMember(true, (stableMax(I)/(Q->P==Q)))) then XP = product(select(stablePrimes(I), Q -> (Q!=P and isSubset(P,Q)==true)));
f := reesMap(I);
R := source f/(sub(I, source f) + ker f);
R := source f/ker f;
IR := sub(I,R);
PR := sub(P,R);
QR := if not(XP===ring I) then sub(P + saturate XP, R) else ideal(1_R);
QR := if not(XP===ring I) then sub(XP, R) else ideal(1_R);
A := quotient(IR, PR);
B := quotient(IR, QR);
B := intersect(quotient(IR, PR), saturate(IR, QR));
A/B
);

Expand Down
Loading