Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomologicalShiftIdeals - A Macaulay2 package for computing the homological shift ideals of a monomial ideal of a polynomial ring #3474

Open
wants to merge 21 commits into
base: development
Choose a base branch
from

Conversation

Antonino-Ficarra
Copy link

@Antonino-Ficarra Antonino-Ficarra commented Sep 12, 2024

A Macaulay2 package for computing the homological shift ideals of a monomial ideal of a polynomial ring

@d-torrance d-torrance changed the base branch from master to development September 12, 2024 10:33
A Macaulay2 package for computing the homological shift ideals of a monomial ideal of a polynomial ring
A Macaulay2 package for computing the matching powers of monomial ideals
@d-torrance
Copy link
Member

Thanks for your contribution!

Both new package files should have the .m2 file extension.

@Antonino-Ficarra
Copy link
Author

Thanks for your contribution!

Both new package files should have the .m2 file extension.

Ok, sorry. I added the ".m2" extension.

Copy link
Author

@Antonino-Ficarra Antonino-Ficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot a semicolon

Copy link
Author

@Antonino-Ficarra Antonino-Ficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot some semicolons

@d-torrance
Copy link
Member

Those semicolons don't really matter. The only time when you definitely need semicolons is when a function body contains multiple statements:

f = x -> (
  statement1;
  statement2;
  statement3;
  statement4)

The other time is when you want to suppress the output when interacting directly with Macaulay2.

L=append(L,mdeg);
);
R:=newRing(S,Degrees=>L);
f:=map(R,S);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same map that was constructed for toMultidegree, but you're applying it to an ideal instead of a ring element. Perhaps you could extract this code into a helper function that both methods could call? (DRY principle when programming -- don't repeat yourself!)

Copy link
Author

@Antonino-Ficarra Antonino-Ficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took into account the precious suggestion of D Torrance

Copy link
Author

@Antonino-Ficarra Antonino-Ficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a typo

Copy link
Author

@Antonino-Ficarra Antonino-Ficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a typo

Copy link
Author

@Antonino-Ficarra Antonino-Ficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a needed flatten

@d-torrance
Copy link
Member

Now the admissableOrder example is failing with the following:

i4 : S = QQ[x,y];

i5 : I = ideal(x^2,y^2);

o5 : Ideal of S

i6 : admissibleOrder I
stdio:6:15:(3): error: the ideal does not have linear quotients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants