Varieties v0.3 #3567
Varieties v0.3 #3567
Conversation
|
@ggsmith @mikestillman is everyone happy with merging this? |
Also changed g \\ f to call quotient'(f, g) instead.
|
It would be good to have this merged soon so the branch is free to continue developing on. |
|
@mikestillman @ggsmith should I go ahead and merge this? We shouldn't wait until a week before the next release to merge big pull requests. |
|
I haven't yet had time to look at the details |
|
You had reviewed the previous PR #3517, which I accidentally closed and had to reopen. I think I've addressed all of your comments there. No other changes have been added since. Do you have an estimate of when you could look at the details? Varieties wasn't updated in version 1.24.05 and again didn't get updated in 1.24.11. There are new features and bug fixes that Devlin and I have worked on, but I'm afraid if we continue it won't make it to 1.25 either. |
|
@mahrud I'm ready to look at your few open PR's. I'm a bit confused about which to do in what order. 3522 first, then 3550, then 3567, then 3582? Are there duplicate commits in these? |
|
You can start from the smallest ones if you prefer, but the order they're reviewed or merged doesn't matter. |
This is a repeat of #3517, which is on top of #3522 and shares a exact few commits with #3526, but I don't believe there should be a conflict.