Update givaro submodule w/ fix for GCC 15 bug #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains fix for GCC 15 bug. [ci skip]
|
The givaro devs just tagged a new release candidate (4.2.1rc0), so I've updated this PR to use that commit instead. |
mikestillman
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
This one looks ready to go. @mahrud, do you think so too?
@d-torrance Do we need to change anything else? Is this working on both cmake and autotools?
|
Yes, it should be good. In particular, the build now works when we build givaro ourselves with GCC 15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The givaro developers have merged linbox-team/givaro#233, which fixes the "no member named 'Low' in 'rint'" compilation failure we were getting with GCC 15.
Closes: #3507