Fix/progress bar memory #1178
Open
Fix/progress bar memory #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some operations that may upload a large amount of files, such as upload_dir, would create a progress bar for each, which may consume large amounts of memory.
WalkDir loads all children for a directory, consuming large ammounts of memory. This function limits the number of files loaded during run in exchange of lexical order.
This will solve large memory consumption during fs walk
Sync is another operation that was consuming a lot of memory.
For when we only need to track the entire amount of bytes needed in the total operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress bar was consuming large amounts of memory due to it having one progress bar per file.
Alongside this, walkdir notably consumes a lot of memory as well.
Lastly, it is better to have a progress report of the sum of the file size instead of the file count, so we update BytesReporter to support these operations.
Notice this is not a PR to main