Photo collection #24
Open
Photo collection #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into idol-collection adding updates from idol-model following review of idol-model pull request
…ant before views are added
…er event and photoset models are added
…into idol-collection merging in typo fix
… photo-model merging idol model changes from master
… idol-collection merging idol model from master
…s without breaking stuff, so taking it back out
…Love into photo-collection Merging in idol-collection
… photo-collection
db0company
reviewed
Oct 2, 2018
|
|
||
| PHOTOS_EXCLUDE = [ | ||
| 'i_skill_type', 'i_leader_skill_stat', 'leader_skill_percentage', 'skill_note_count', 'skill_percentage', 'i_sub_skill_type', 'sub_skill_amount', 'sub_skill_percentage', | ||
| ] + [ |
There was a problem hiding this comment.
Why do you have it in 2 concatenated lists instead of a single list? 🤔
| title = _('Photo') | ||
| plural_title = _('Photos') | ||
| icon = 'cards' | ||
| navbar_title = _('Photos') |
There was a problem hiding this comment.
I think you don't need to specify the navbar title if it's the same as the plural title, it will just use it.
| def to_fields(self, view, item, *args, **kwargs): | ||
| _photo_images = PHOTO_IMAGES.copy() | ||
| _photo_images.update({'color': '{static_url}img/color/{value}.png'.format(**{'value':item.color, 'static_url':RAW_CONTEXT['static_url']}), | ||
| 'rarity': '{static_url}img/rarity/{value}.png'.format(**{'value':item.rarity, 'static_url':RAW_CONTEXT['static_url']})}) |
There was a problem hiding this comment.
You can use staticImageURL in magi.utils here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding photo collection, switched mic.png to a bigger version