Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update app version #6

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

update app version #6

wants to merge 15 commits into from

Conversation

djylb
Copy link

@djylb djylb commented Nov 6, 2021

No description provided.

@di72nn
Copy link
Collaborator

di72nn commented Nov 7, 2021

Hey!

Thanks for your contribution!

Unfortunately, I have some issues with the changes:

  • There is at least one report that 1.7.14 (220) is problematic on Android 11, so I don't want to update it in the module yet (because 119 can be updated to 220 on the device, but not the other way around).
  • Why do you add all these permissions to the privapp-permissions list?
  • I also don't see the point of bumping the Magisk version requirement just yet.

@djylb
Copy link
Author

djylb commented Nov 17, 2021

Sorry to see your reply now.
When I use your old version, it does work on Android12, but after I update it through F-Droid, it does not work, and there is a permission problem. I am not sure where the problem is, so I put all the permissions needed for the new version of the APP All are added to the privapp-permissions list.
Fortunately, the APP can work normally after flashing in the modified plug-in. I am not sure which permissions are necessary, and unnecessary permissions may be added.

@di72nn
Copy link
Collaborator

di72nn commented Nov 17, 2021

It is likely to be caused by the updated targetSdkVersion in 1.7.14.
If so, it should be fixed in the app itself (not in the Magisk module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants