Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/3784/improve quantile diagramm #3827

Merged
merged 22 commits into from
Dec 20, 2024

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Nov 20, 2024

Improving the quantile color diagram

Closes: #3784

Description

  • Made the diagram bigger
  • Added a cross so one can see the exact values when hovering the diagram

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

Screenshot 2024-11-20 at 19 18 24

@BenediktMehl BenediktMehl force-pushed the feat/3784/improve-quantile-diagramm branch from 0740dac to 97b9a45 Compare November 27, 2024 10:17
@BenediktMehl BenediktMehl force-pushed the feat/3784/improve-quantile-diagramm branch from 7712660 to bbd4562 Compare December 17, 2024 13:23
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
BenediktMehl added a commit that referenced this pull request Dec 17, 2024
@BenediktMehl BenediktMehl force-pushed the feat/3784/improve-quantile-diagramm branch from 4952524 to 44bff5d Compare December 17, 2024 14:05
@IhsenBouallegue
Copy link
Collaborator

IhsenBouallegue commented Dec 19, 2024

The code looks good and it works for me too. The slider inputs don't have to be that big as it they are just for 2 digits. But this is not a blocker just something caused by the menu becoming bigger. I realized it was like that the whole time with the slider.

@IhsenBouallegue IhsenBouallegue force-pushed the feat/3784/improve-quantile-diagramm branch from 44bff5d to 54c05f7 Compare December 20, 2024 09:09
Copy link

Copy link

@IhsenBouallegue IhsenBouallegue merged commit 51df7e2 into main Dec 20, 2024
8 checks passed
@IhsenBouallegue IhsenBouallegue deleted the feat/3784/improve-quantile-diagramm branch December 20, 2024 09:39
IhsenBouallegue pushed a commit that referenced this pull request Dec 20, 2024
IhsenBouallegue pushed a commit that referenced this pull request Dec 20, 2024
IhsenBouallegue pushed a commit that referenced this pull request Dec 20, 2024
IhsenBouallegue pushed a commit that referenced this pull request Dec 20, 2024
IhsenBouallegue pushed a commit that referenced this pull request Dec 20, 2024
IhsenBouallegue pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigger Quantile-Diagramm in color options for distribution of metric values
2 participants