Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_local_notifications] Add support to pass bubble activity + intent to notification #2484

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Airyzz
Copy link

@Airyzz Airyzz commented Dec 6, 2024

This allows for use of Android conversation bubbles api

@Levi-Lesches
Copy link
Contributor

Levi-Lesches commented Dec 6, 2024

Interesting! Perhaps you can make another Dart class for the bubble details? That way they stay bundled together and you can just use ?. to check its members instead of checking each one independently (eg, what happens if bubbleActivity == null && bubbleExtra != null? This way you can just make AndroidBubble.activity be required and AndroidBubble.extra be nullable).

Then be sure to properly handle the error case in your Java code.

And of course, please be sure to document the Dart parts, any extra Android-specific setup, and add a test case if possible, and let us know when you're finished. I'd be happy to test on my end as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants