Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Link not found #115

Closed
codely8 opened this issue Dec 14, 2020 · 10 comments · Fixed by #114 or #116
Closed

Link not found #115

codely8 opened this issue Dec 14, 2020 · 10 comments · Fixed by #114 or #116
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@codely8
Copy link
Member

codely8 commented Dec 14, 2020

I started the game, i ended up in a page
where it shows like this
image
When i click the link it took me to 404 page of github.
Please take a note.

@ghost
Copy link

ghost commented Dec 14, 2020

Looks like the issue is with wrong relative url. If you want, you can fix it.

Just fork the repo, create a new branch, edit the WIP.md file. Change the link from ../../../README.md#contribution-guidelines to ../../README.md#contribution-guidelines

@ghost
Copy link

ghost commented Dec 14, 2020

Please make sure you read the contribution docs as well before doing this. It can be found in the readme file.

@codely8
Copy link
Member Author

codely8 commented Dec 14, 2020

I read the docs and change the URL. it worked fine.

@ghost
Copy link

ghost commented Dec 14, 2020

Then you are ready to make a pull request 👍

@codely8
Copy link
Member Author

codely8 commented Dec 14, 2020

I did it in the fork repo.

@ghost
Copy link

ghost commented Dec 14, 2020

Did you make a Pull Request? If not, please do it. Then only we can merge it into this repo.

@ghost
Copy link

ghost commented Dec 14, 2020

I see that you created a pull request in your fork. That is not the way of doing it. Please create a Pull Request again and make sure you point the base branch to this repo.

@codely8 codely8 mentioned this issue Dec 14, 2020
@ming-tsai
Copy link
Member

Hi @Codely-F, is this issue is solved on #116 ?

@ming-tsai ming-tsai added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Dec 14, 2020
@ghost
Copy link

ghost commented Dec 14, 2020

Right now the hyperlink points to #112 based on @Arsenic-ATG's PR. Nice job anyway @Codely-F .

This was linked to pull requests Dec 14, 2020
@ming-tsai
Copy link
Member

Ok, thanks @paulsonjpaul.
This issue will be closed, if the bug is persisted you could reopen it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants