Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Update wip.md #116

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Update wip.md #116

merged 3 commits into from
Dec 14, 2020

Conversation

codely8
Copy link
Member

@codely8 codely8 commented Dec 14, 2020 •
edited
Loading

I have updated the link
from ../../../README.md#contribution-guidelines to ../../README.md#contribution-guidelines

Addresses #115

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ghost
ghost approved these changes Dec 14, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@ghost
Copy link

ghost commented Dec 14, 2020

Please check this @ming-tsai

@ghost
Copy link

ghost commented Dec 14, 2020

@Codely-F can you please edit your first post and add Addresses #115?

@codely8
Copy link
Member Author

codely8 commented Dec 14, 2020

Done with editing the post.

@Arsenic-ATG Arsenic-ATG mentioned this pull request Dec 14, 2020
Merged
Arsenic-ATG
Arsenic-ATG approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@Arsenic-ATG Arsenic-ATG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ming-tsai I would recommend going for a squash merge on this one as all three commits are doing the same task and it is better to perform one single commit doing so to keep the development tree clean.

@ming-tsai ming-tsai merged commit 5f369e1 into MakeContributions:master Dec 14, 2020
@ming-tsai
Copy link
Member

@ming-tsai I would recommend going for a squash merge on this one as all three commits are doing the same task and it is better to perform one single commit doing so to keep the development tree clean.

Done

@ming-tsai
Copy link
Member

Hi @Codely-F, nice work and welcome to our team

@ming-tsai ming-tsai mentioned this pull request Dec 14, 2020
Closed
This was linked to issues Dec 14, 2020
Link not found #115
Closed
Add more dungeons, rooms or floors - Part 3 #103
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Arsenic-ATG Arsenic-ATG Arsenic-ATG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link not found Add more dungeons, rooms or floors - Part 3
3 participants
@codely8 @ming-tsai @Arsenic-ATG