Added way for PolarAxis to pull fontsize attribute from Figure #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the "rticklabelsize" and "thetaticklabelsize" properties in the "types.jl" file to fall back to inheriting the fontsize from the Figure, if the ticklabelsize is not defined. This fixes issue MakieOrg#3928 (MakieOrg#3928).
asinghvi17
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Looks good to me. Do you want to add a reference image test to make sure this works?
To do so, simply add another @reference_test block at the end of this file. https://github.com/MakieOrg/Makie.jl/blob/master/ReferenceTests/src/tests/figures_and_makielayout.jl
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Reference image changes are because the default font size in the polar axis is now inheriting from the default 14, not 16 as it was when the recipe was written. Given that this restores consistency with |
|
Could you also add a short entry in the CHANGELOG.md about the PR? Thanks! |
asinghvi17
reviewed
Sep 4, 2024
…4314 yticklabelsize now propagates into rticklabelsize instead of thetaticklabelsize and xticklabelsize now propagates into thetaticklabelsize
> Actually I think this would be better as unit tests. There is already a refimg test for decorations that should confirm that changing r-/thetaticklabelsize has the desired effect. So here you just need to confirm that the PolarAxis is correctly inheriting values.
asinghvi17
reviewed
Sep 5, 2024
ffreyer
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #3928.
Adjusted the "rticklabelsize" and "thetaticklabelsize" properties in the "types.jl" file to fall back to inheriting the fontsize from the Figure, if the ticklabelsize is not defined.
Type of change
Checklist