Add option strip_zero for MultiplesTicks
#4372
Open
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuncbkose
force-pushed
the
multiples_ticks
branch
from
a24ea35
to
c91f08e
Compare
|
I'm not sure how to add tests for these, even after reading |
|
Some checks like mt = MultipleTicks(...)
@test get_ticks(...) == ...in https://github.com/MakieOrg/Makie.jl/blob/master/test/makielayout.jl would be good I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4370
Adds a new option
strip_zero::BooltoMultiplesTicksand related logic toget_ticksthat strips labels of the form0xto0.Type of change
Delete options that do not apply:
Checklist