Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eeg_topoplot labels fix #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

eeg_topoplot labels fix #54

wants to merge 3 commits into from

Conversation

behinger
Copy link
Collaborator

As of now, the labels in the eeg_topoplot have not every worked (strange, but oh well..).

In any case, I fixed this now, but I also moved labels from a positional argument to a keyword argument. I think this makes much more sense, you can either specify positions, labels or both.

One argument could be made to make positions a positional argument, like in topoplot itself and overload it, but I didnt manage with convert argument, and I think this way it is ok.

This is a breaking change.

PS: I might want to adress few other issues which might be breaking too (e.g. #38), so please hold with new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant