This repository has been archived by the owner on Nov 4, 2022. It is now read-only.
Fixed a crash when the adapter still triggers the update of the previous recycler view #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce the bug:
adapterto a SuperRecyclerView instancerecyclerView:recyclerView.setAdapter(adapter)recyclerView:recyclerView.setAdapter(null).adapter.notifyDataSetChanged().The
recyclerViewwill get notified since the observer is not cancelled. But now,recyclerView.getAdapter()will returnnull, this will crash whenrecyclerView.getAdapter().getCount()is called.This PR fixed this issue by cancelling the observation once the adapter is changed. (Essentially this is how the official RecyclerView handles adapter changing.)