Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adam): StreamingPackageInstallRequest should return parseable response for errors #117

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Malinskiy
Copy link
Owner

Breaks compatibility, but a boolean was not enough

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (6cd8361) to head (e67ab9c).

Files Patch % Lines
...adam/request/pkg/StreamingPackageInstallRequest.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
- Coverage     80.18%   80.16%   -0.02%     
  Complexity      707      707              
============================================
  Files           143      143              
  Lines          3194     3197       +3     
  Branches        547      548       +1     
============================================
+ Hits           2561     2563       +2     
  Misses          367      367              
- Partials        266      267       +1     
Flag Coverage Δ
integration 63.74% <80.00%> (+0.31%) ⬆️
unit 70.65% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malinskiy Malinskiy merged commit f206bc9 into master Aug 14, 2024
28 of 29 checks passed
@Malinskiy Malinskiy deleted the feature/streaming_install_response branch August 14, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant