Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about which download types are non-production/PoC #1165

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add note about which download types are non-production/PoC #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions site/_assets/css/_type.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ th {
border-bottom: 1px solid var(--color-border-heading);
}

tfoot {
font-size: 0.75em;
}

ul {
margin: 0 0 1em 0;
}
Expand Down
2 changes: 2 additions & 0 deletions site/_data/download_types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- name: Docker
download_platform: docker
poc: true

- name: Google Cloud Platform
download_platform: gce
Expand Down Expand Up @@ -46,6 +47,7 @@
- name: Vagrant
download_platform: vagrant
ext: box
poc: true

- name: VMware vSphere
download_platform: vsphere
Expand Down
39 changes: 23 additions & 16 deletions site/_includes/download/release_table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,30 @@
{% assign release = include.release %}
<div class="table-responsive">
<table class="table table-bordered table-hover">
<tr>
<th>Appliance</th>
<th>Format</th>
<th>Size</th>
<th>MD5</th>
</tr>
{% for type in site.data.download_types %}
{% assign data = type.download_platform | data_for: release.branch, release.tag, release.filename, type.ext %}
{% assign url = data[0] %}
{% assign file_size = data[1]["size"] %}
{% assign md5 = data[1]["md5"] %}
<tbody>
<tr>
<td><a href="{{ url }}" onClick="{{ type.download_platform | on_click_for_download: type.name, release.name }}">{{ type.name }}</a></td>
<td>{{ type.download_platform }}</td>
<td>{{ file_size }}</td>
<td>{{ md5 }}</td>
<th>Appliance</th>
<th>Format</th>
<th>Size</th>
<th>MD5</th>
</tr>
{% endfor %}
{% for type in site.data.download_types %}
{% assign data = type.download_platform | data_for: release.branch, release.tag, release.filename, type.ext %}
{% assign url = data[0] %}
{% assign file_size = data[1]["size"] %}
{% assign md5 = data[1]["md5"] %}
<tr>
<td><a href="{{ url }}" onClick="{{ type.download_platform | on_click_for_download: type.name, release.name }}">{{ type.name }}</a>{% if type.poc %} *{% endif %}</td>
Copy link
Member Author

@Fryguy Fryguy Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is weird because I added a <tbody> which indented things, but there only change aside from the tfoot is here to add a * after the name.

Hide whitespace diff makes it clearer

<td>{{ type.download_platform }}</td>
<td>{{ file_size }}</td>
<td>{{ md5 }}</td>
</tr>
{% endfor %}
</tbody>
<tfoot>
<tr>
<td colspan="4">* Intended for proof of concept and non-production use cases.</td>
</tr>
</tfoot>
</table>
</div>