Move ref docs menus to manageiq-documentation branches #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
move_menus_to_docs_repo
branch
from
17869f4
to
eb88e89
Compare
Fryguy
changed the title
Fryguy
commented
Oct 20, 2020
| Miq.menus_dir.glob("ref_menu_*.yml").sort.map(&:to_s).tap do |menus| | ||
| latest = menus.index { |m| m.include?("ref_menu_latest.yml") } | ||
| menus << menus.delete_at(latest) if latest | ||
| end |
There was a problem hiding this comment.
This part is needed to deal with someone doing bin/miq serve directly but without building the docs. Previously the menu files would exist and this would be fine, but now they won't exist unless one builds the docs first.
|
This PR will be red until the dependent PRs are merged...Unfortunately, since it's multiple branches, I can't do any kind of cross-repo thing with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
@chessbyte Please review.
Related to #814