[F] Use query params in admin #3653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1aurend
force-pushed
the
ld/mnfld-569
branch
from
c370351
to
dcf37b7
Compare
1aurend
force-pushed
the
ld/mnfld-569
branch
from
dcf37b7
to
d30e774
Compare
|
@dananjohnson It looks to me like this is basically done, and the only conflicts are snapshots that can be deleted. I'd need to update the new spam mitigation list views to match this and do a little testing, but it seems worth getting in? |
|
@1aurend that's great! Yeah I agree—it's worth merging and then utilizing in the new list views. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies how list pagination and filters are handled between the frontend and admin mode, using query params wherever a route's primary purpose is to display a single list. Pagination links are also changed to buttons rather than anchors where no valid href exists, e.g. on pages displaying multiple paginated lists.