-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contributing): add manim.typing guide #3669
Conversation
d38fc83
to
f917dc3
Compare
If anyone wants to write a quick description on the different representations of Béziers in Manim, feel free to push a commit adding it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your effort!
I left some comments around the document.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
2319d51
to
a6d8212
Compare
a6d8212
to
c2ebbde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
It's important to document the intention behind each
TypeAlias
present in themanim.typing
module, as well as explain when to use each. For example,InternalPoint3D
vsVector3D
have very different connotations, but the same signature.From the guide:
Link to Changed Documentation
https://manimce--3669.org.readthedocs.build/en/3669/contributing/docs/types.html
Progress
CC @Viicos