Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized manim.utils.bezier.get_smooth_cubic_bezier_handle_points() #3767

Merged
merged 8 commits into from
Jun 26, 2024
Merged

Optimized manim.utils.bezier.get_smooth_cubic_bezier_handle_points() #3767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89c903f
Optimized manim.utils.get_smooth_cubic_bezier_handle_points()
chopan050 May 16, 2024
2f8c652
Fixed typo in docstring regarding vector u
chopan050 May 17, 2024
2f01470
Merge branch 'main' into optimize-get-smooth-cubic-handles
chopan050 May 22, 2024
111dd92
Merge branch 'main' into optimize-get-smooth-cubic-handles
chopan050 May 22, 2024
502d143
Merge branch 'main' of https://github.com/ManimCommunity/manim into o…
chopan050 Jun 24, 2024
edbefdb
Merge branch 'main' of https://github.com/ManimCommunity/manim into o…
chopan050 Jun 26, 2024
2bba9dc
Add tests for get_smooth_cubic_bezier_handle_points
chopan050 Jun 26, 2024
ee672f4
Fix backreference in test docstrings
chopan050 Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manim/mobject/types/vectorized_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
from manim.utils.bezier import (
bezier,
bezier_remap,
get_smooth_handle_points,
get_smooth_cubic_bezier_handle_points,
integer_interpolate,
interpolate,
partial_bezier_points,
Expand Down Expand Up @@ -1093,7 +1093,7 @@ def change_anchor_mode(self, mode: Literal["jagged", "smooth"]) -> Self:
# The append is needed as the last element is not reached when slicing with numpy.
anchors = np.append(subpath[::nppcc], subpath[-1:], 0)
if mode == "smooth":
h1, h2 = get_smooth_handle_points(anchors)
h1, h2 = get_smooth_cubic_bezier_handle_points(anchors)
else: # mode == "jagged"
# The following will make the handles aligned with the anchors, thus making the bezier curve a segment
a1 = anchors[:-1]
Expand Down
Loading
Loading