Add new method of specifying seed and using warnings.warn #3908
+186
−181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This pull request
random_seed
from a__init__
argument to a class variable, and deprecates the argument in__init__
manim.utils.deprecation
warnings
to uselogging
.manim.utils.deprecation
to usewarnings.warn
Motivation and Explanation: Why and how do your changes improve the library?
It's fairly tedious to set the seed via
It's much nicer to do
This also is similar to how it works on the experimental branch.
As for using
warnings.warn
, this allows us to use the pytest warnings mechanism, which gives better error messages when testing warnings.Reviewer Checklist