-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash due to bad rounding in BarChart when no y_step was provided and the max y value was close to 0 #3935
Open
zeFresk
wants to merge
15
commits into
ManimCommunity:main
Choose a base branch
from
zeFresk:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8b20941
Fix automatic BarChart y_step deduction when none is provided by the …
zeFresk 9f5c2df
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb18bba
Do not round to less than 2 digits to ensure retrocompatibility
zeFresk 49f9e26
Merge branch 'main' of github.com:zeFresk/manim
zeFresk 232924f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6f4de6e
Added test for small values inside BarChart
zeFresk 7517886
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9f626ae
Temporary commit to ensure that previous version fails newly added test
zeFresk 520dc33
Merge branch 'main' of github.com:zeFresk/manim
zeFresk 5ca9536
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 000d689
Going back to changes, test correctly checks fix
zeFresk 0bd2af3
Merge branch 'main' into main
zeFresk 14d1b17
Added comments above the formula
zeFresk 9fcfe39
Merge branch 'main' of github.com:zeFresk/manim
zeFresk e1ae442
Fix linting
zeFresk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to
In the first commit (used for my renderings), I also added this change because a range from 0 to 0.000001 was not considered strictly positive or negative for some reason. I later reversed this change because it seemed to break a lot of tests. Maybe this is the cause of your troubles.