Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Prism rendering #4003

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix Prism rendering #4003

wants to merge 6 commits into from

Conversation

ra1u
Copy link

@ra1u ra1u commented Nov 9, 2024

Fixes Prism, that shows cube of size 2.

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for your contribution!

I have a slightly different suggestion for a more sustainable fix that takes care of the situation for all subclasses of Cube. Please take a look!

manim/mobject/three_d/three_dimensions.py Outdated Show resolved Hide resolved
@behackl behackl added the enhancement Additions and improvements in general label Nov 24, 2024
@JasonGrace2282
Copy link
Member

Hey, I'm a little bit confused about what problem this fixes. Is there a minimal reproducible example of the problem?

@ra1u
Copy link
Author

ra1u commented Dec 7, 2024

This bug can be observed when renderer is opengl

manim render --renderer opengl prism_bug.py

prism_bug.py:

from manim import *

class PrismBug(Scene):
    def construct(self):
        self.add(Prism(dimensions=[1,2,3]))

output:

Failed:
PrismBug_ManimCE_v0 18 1_bug

Expected (after patch):
PrismBug_ManimCE_v0 18 1_ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions and improvements in general
Projects
Status: 👍 To be merged
Development

Successfully merging this pull request may close these issues.

3 participants