Fix return type of Polygram.get_vertex_groups()
and rename variables in .round_corners()
#4063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polygram.get_vertex_groups()
returns a sequence of point arrays representing the vertex groups ofPolygram
. Currently, it tries to return a single 3D NumPy array, but that assumes that all the vertex groups have the same length, which does not always happen. When it doesn't happen, this function crashes.Instead, this PR modifies this method to return a
list[Point3D_Array]
: a list of 2D NumPy arrays.Plus, this PR renames variables in
Polygram.round_corners()
:vertices -> vertex_group
currentRadius -> current_radius
nonZeroLengthArcs -> nonzero_length_arcs
totalCurveCount -> num_curves
averageLengthPerCurve -> average_arc_length
Links to added or changed documentation pages
https://manimce--4063.org.readthedocs.build/en/4063/reference/manim.mobject.geometry.polygram.Polygram.html#manim.mobject.geometry.polygram.Polygram.get_vertex_groups
Reviewer Checklist