Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #4027, type aliases such as
VectorNDLike
andVectorNDLike_Array
were necessary, because there were many functions and methods in which we can represent some direction using a tuple/list of floats.The clearest example would be the
Vector
Mobject. It accepts adirection
as a parameter, which was typehinted as aPoint2DLike | Point3DLike
becauseVector2D | Vector3D
can only represent a NumPy array, whereasPoint2DLike | Point3DLike
can also represent a tuple or list. This is inconsistent and signals us that we actually needVector2DLike
andVector3DLike
type aliases.TODOs in follow-up PRs:
path_ops.py
,space_ops.py
andthree_dimensions.py
, among others. Many parameters are simply typed asnp.ndarray
. I detected that thePathFuncType
actually seems to interpolate twoPoint3D_Array
objects, notPoint3DLike
.Quaternion
type alias, and maybe alsoMatrix3x3
.OpenGLMobject.wag()
, becauseMobject.wag()
was deprecated and removed.Links to added or changed documentation pages
Reviewer Checklist