Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): missing role name in Key Participant card #87

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

GabDug
Copy link
Collaborator

@GabDug GabDug commented Jul 18, 2024

Role name was always defaulting to FireFighter

@GabDug GabDug self-assigned this Jul 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.89%. Comparing base (9741726) to head (9507f91).

Files Patch % Lines
...ter/incidents/templates/pages/incident_detail.html 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   62.87%   62.89%   +0.02%     
==========================================
  Files         213      213              
  Lines        9431     9431              
  Branches     1276     1276              
==========================================
+ Hits         5930     5932       +2     
+ Misses       3293     3292       -1     
+ Partials      208      207       -1     
Flag Coverage Δ
unittests 62.89% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabDug GabDug merged commit 34d6fc9 into main Jul 18, 2024
4 checks passed
@GabDug GabDug deleted the fix/no-role-in-ui branch July 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants