Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow xcm-transacts from all chains #1055

Merged
merged 9 commits into from
Jul 12, 2023
Merged

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Mar 29, 2023

Description

  • Allow xcm Transact instructions to be executed
  • Added barrier that makes sure such xcm messages have DescenOrigin first so they and pays for their own execution via WithdrawAsset|BuyExecution with an address that is not the sovereign of the sender chain.
  • That address is created by hashing the origin of the sender location so it should be unique for each address on each chain.

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@github-actions
Copy link

github-actions bot commented Mar 29, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev self-assigned this Apr 3, 2023
@ghzlatarev ghzlatarev added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-xcm Area: Issues and PRs related to Cross-Consensus Messaging (XCM) A-dolphin Area: Issues and PRs related to the Dolphin Runtime L-added Log: Issues and PRs related to addition C-enhancement Category: An issue proposing an enhancement or a PR with one labels Apr 3, 2023
@ghzlatarev ghzlatarev changed the title Allow xcm-trasnacts from all chains Allow xcm-transacts from all chains Apr 11, 2023
@ghzlatarev ghzlatarev marked this pull request as ready for review July 12, 2023 04:50
Signed-off-by: Georgi Zlatarev <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above target_daily_congestion_cost_kma

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above target_daily_congestion_cost_kma

@ghzlatarev ghzlatarev merged commit 5c37a5d into manta Jul 12, 2023
35 checks passed
@ghzlatarev ghzlatarev deleted the ghzlatarev/xcm-transact branch July 12, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-xcm Area: Issues and PRs related to Cross-Consensus Messaging (XCM) C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants