Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 arc-runner patch 1.1 #1241

Merged
merged 7 commits into from
Aug 1, 2023
Merged

🐛 arc-runner patch 1.1 #1241

merged 7 commits into from
Aug 1, 2023

Conversation

anaye1997
Copy link
Contributor

@anaye1997 anaye1997 commented Jul 31, 2023

Description

🐛 fix pipeline syntax, put shell: bash at right place


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@anaye1997 anaye1997 added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-automation Area: Issues and PRs related to Automation L-added Log: Issues and PRs related to addition labels Jul 31, 2023
@anaye1997 anaye1997 changed the title 🐛 fix pipeline syntx, put shell: bash at right place 🐛 fix pipeline syntax, put shell: bash at right place Jul 31, 2023
@anaye1997 anaye1997 changed the title 🐛 fix pipeline syntax, put shell: bash at right place 🐛 arc-runner patch 1.1 Jul 31, 2023
grenade
grenade previously approved these changes Jul 31, 2023
Copy link
Contributor

@grenade grenade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
@anaye1997 anaye1997 removed A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime labels Aug 1, 2023
@anaye1997 anaye1997 added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime labels Aug 1, 2023
@ghzlatarev ghzlatarev merged commit 32dc59a into manta Aug 1, 2023
56 checks passed
@ghzlatarev ghzlatarev deleted the feature/arc-runner-patch-2 branch August 1, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants