Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native asset barrier #1247

Open
wants to merge 75 commits into
base: manta
Choose a base branch
from
Open

Native asset barrier #1247

wants to merge 75 commits into from

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Aug 16, 2023

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

ghzlatarev and others added 19 commits August 11, 2023 09:35
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
…ay limit without skipping days

Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
…l mocks. Unit and integration tests passing

Signed-off-by: Georgi Zlatarev <[email protected]>
…ate weights file with dummy values

Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
…ded, add some additional checks

Signed-off-by: Georgi Zlatarev <[email protected]>
runtime/manta/src/lib.rs Outdated Show resolved Hide resolved
@ferrell-code
Copy link
Contributor

ferrell-code commented Aug 22, 2023

I need to add the barrier in each extrinsic. Was thinking of putting in the base call filter but there i can't get the origin.

I think we can use SignedExtra to check the barrier here

pub type SignedExtra = (

and not fork balances

@ghzlatarev ghzlatarev requested a review from a team as a code owner August 31, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-unit-test-checks A-xcm Area: Issues and PRs related to Cross-Consensus Messaging (XCM) C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily limit for outgoing xcm transfers of native asset
2 participants