Fix Error on published Custom Banner

Mantan21 · Oct 29, 2024 · b1c4bab · b1c4bab
1 parent 970fdeb
commit b1c4bab
Show file tree

Hide file tree

Showing 11 changed files with 9 additions and 15 deletions.
diff --git a/src/routes/_allbanners/_item-banner.svelte b/src/routes/_allbanners/_item-banner.svelte
@@ -61,7 +61,6 @@
 							use:lazyLoad={imageCDN(images)}
 							data-placeholder={$assets['placeholder-general.webp']}
 							alt={character}
-							crossorigin="anonymous"
 							loading="lazy"
 						/>
 					{:else}

diff --git a/src/routes/_custom-banner/BannerEditor/BannerArt.svelte b/src/routes/_custom-banner/BannerEditor/BannerArt.svelte
@@ -96,7 +96,7 @@
 	<div class="zoomist-container" bind:this={mainArt}>
 		<div class="zoomist-wrapper">
 			<div class="zoomist-image">
-				<img src={artURL} alt="Uploaded Splash Art" crossorigin="anonymous" />
+				<img src={artURL} alt="Uploaded Splash Art" />
 			</div>
 		</div>
 	</div>

diff --git a/src/routes/_custom-banner/ModalDelete.svelte b/src/routes/_custom-banner/ModalDelete.svelte
@@ -71,12 +71,7 @@
 				{/if}
 
 				{#if thumbnail}
-					<img
-						use:lazyLoad={thumbnail}
-						alt="Delete this banner"
-						class="selectedToDelete"
-						crossorigin="anonymous"
-					/>
+					<img use:lazyLoad={thumbnail} alt="Delete this banner" class="selectedToDelete" />
 				{/if}
 			</div>
 		{/if}

diff --git a/src/routes/_custom-banner/ModalInitBanner.svelte b/src/routes/_custom-banner/ModalInitBanner.svelte
@@ -129,7 +129,7 @@
 					</caption>
 				{/if}
 				{#if thumbnail}
-					<img src={thumbnail} alt="Banner Thumbnail" class="thumb" crossorigin="anonymous" />
+					<img src={thumbnail} alt="Banner Thumbnail" class="thumb" />
 				{/if}
 			</div>
 		{/if}

diff --git a/src/routes/_custom-banner/SplashArtEditor/SplashArt.svelte b/src/routes/_custom-banner/SplashArtEditor/SplashArt.svelte
@@ -24,6 +24,7 @@
 	export let weaponType = '';
 	export let localName = '';
 	export let hideInfo = false;
+	export let isCustom = false;
 
 	let mainArt;
 	let clientHeight = 0;
@@ -171,7 +172,7 @@
 					<img
 						src={artURL}
 						alt={localName || character}
-						crossorigin="anonymous"
+						{...!isCustom ? { crossorigin: 'anonymous' } : {}}
 						on:load={() => movePos(position?.splashArt || {})}
 					/>
 				</div>

diff --git a/src/routes/_gachainfo/details/_promotional-v1.svelte b/src/routes/_gachainfo/details/_promotional-v1.svelte
@@ -30,7 +30,7 @@
 				<i class="gi-{character.vision} {character.vision} icon-gradient filter-drop" />
 				{#if $isCustomBanner}
 					{@const { images = {}, character = '' } = $customData || {}}
-					<img use:lazyLoad={images?.faceURL} alt={character} crossorigin="anonymous" />
+					<img use:lazyLoad={images?.faceURL} alt={character} />
 				{:else}
 					<img
 						use:lazyLoad={$assets[`face/${character.name}`]}

diff --git a/src/routes/_gachainfo/details/_promotional-v2.svelte b/src/routes/_gachainfo/details/_promotional-v2.svelte
@@ -44,7 +44,6 @@
 								use:lazyLoad={images?.faceURL}
 								data-placeholder={$assets['face-placeholder.webp']}
 								alt={name}
-								crossorigin="anonymous"
 							/>
 						{:else}
 							<img

diff --git a/src/routes/_inventory/_inventory-detail.svelte b/src/routes/_inventory/_inventory-detail.svelte
@@ -90,6 +90,7 @@
 	artURL={getArtURL(outfitName)}
 	position={offset}
 	preview
+	isCustom={custom}
 	{weaponType}
 	{localName}
 	{vision}

diff --git a/src/routes/_inventory/_inventory-item.svelte b/src/routes/_inventory/_inventory-item.svelte
@@ -44,7 +44,6 @@
 				use:lazyLoad={images?.faceURL}
 				data-placeholder={$assets['placeholder-face.webp']}
 				alt={localName}
-				crossorigin="anonymous"
 			/>
 			<span class="gi-{vision} {vision} icon-gradient element" />
 		{:else if type === 'character'}

diff --git a/src/routes/_wish/wish-result/_result-list-item.svelte b/src/routes/_wish/wish-result/_result-list-item.svelte
@@ -44,7 +44,7 @@
 				{@const { artURL } = status === 'owned' ? images : hostedImages}
 				{@const { wishCard = {} } = artPosition || {}}
 				<div class="zoomist-image" style={getCssVarPosition(wishCard, clientHeight, clientWidth)}>
-					<img src={artURL} alt={name} class="wishpic" crossorigin="anonymous" />
+					<img src={artURL} alt={name} class="wishpic" />
 				</div>
 
 				<!-- Weapon -->

diff --git a/src/routes/_wish/wish-result/_splash-art.svelte b/src/routes/_wish/wish-result/_splash-art.svelte
@@ -22,7 +22,7 @@
 		{@const { artURL } = status === 'owned' ? images : hostedImages}
 		{@const { splashArt = {} } = artPosition || {}}
 		<div class="zoomist-image" style={pos(splashArt, clientHeight, clientWidth)}>
-			<img use:lazyLoad={artURL} alt={name} crossorigin="anonymous" />
+			<img use:lazyLoad={artURL} alt={name} />
 		</div>
 
 		<!-- Weapon -->